Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win processes ("System" name) #17704

Merged
merged 13 commits into from
May 24, 2024
Merged

Conversation

thiagoftsm
Copy link
Contributor

@thiagoftsm thiagoftsm commented May 20, 2024

Summary

Blocked by #17693
This is the first pull request (PR) in a series aimed at creating compatibility between what is delivered on Linux/BSD and Microsoft systems.

This PR does not include all possible metrics available to 'System.' Instead, it focuses solely on the metrics we provide in 'System Overview -> processes.'

There is one exception to this rule: since threads are particularly important on Windows, we have added a new chart specifically for them.

Processes:
processes

Context switch:
ctx

Thread:
threads

Test Plan
  1. Compile this PR on Linux and verify we still have charts on it.
  2. Compile this PR on Windows, and verify we have processes submenu there.
Additional Information
For users: How does this change affect me?

@thiagoftsm thiagoftsm requested review from vkalintiris and a team as code owners May 20, 2024 01:44
@github-actions github-actions bot added area/collectors Everything related to data collection area/build Build system (autotools and cmake). collectors/proc labels May 20, 2024
@thiagoftsm thiagoftsm requested a review from stelfrag May 20, 2024 01:44
@thiagoftsm thiagoftsm force-pushed the win_processes branch 2 times, most recently from 8180a2e to 282b019 Compare May 21, 2024 01:12
@thiagoftsm thiagoftsm marked this pull request as ready for review May 24, 2024 00:07
@thiagoftsm thiagoftsm merged commit 7493463 into netdata:master May 24, 2024
145 of 149 checks passed
@thiagoftsm thiagoftsm deleted the win_processes branch May 24, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Build system (autotools and cmake). area/collectors Everything related to data collection collectors/proc collectors/windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants